fix: secure session handling and landing page redirect#462
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
| @@ -0,0 +1,22 @@ | |||
| package utils | |||
There was a problem hiding this comment.
can we have some tests for this? since it is a critical function
|
@its-me-abhishek The CI failure was in date-time-picker.test.tsx ,the test hardcoded February 2026 as the expected calendar month, so it fails every month that isn't February 
after fixing this , all the tests pass successfully. |
yes, please do! |
I have updated the code and now all the tests pass |
| return | ||
| } | ||
|
|
||
| // Inject session credentials into headers for GET requests |
There was a problem hiding this comment.
this does not seem to be a good idea... or is it? can you please provide some information on how would this exactly work?
2 participants
Description
Increase session cookie lifetime to 30 days.
Fix secure cookie handling behind ingress using dynamic Secure flag and helper save function.
Inject authenticated user credentials into request headers/body using AuthMiddleware so handlers always receive correct user info.
Fixes: I have to log in all the time #417
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes